Port fix for Update how certain cache directives are handled to 1.1.x

Question

Port fix for Update how certain cache directives are handled to 1.1.x

JunTaoLuo opened this issue 8 years ago · 5 comments

JunTaoLuo commented 8 years ago

We'll need to port back part of the fixes in #88 back to 1.1.x.

At the minimum we'll need the fixes to:

Always add the IResponseCachingFeature before calling the next middleware #81
Use If-Modified-Since instead of the wrong If-Unmodified-Since header for conditional requests

Also potentially consider

handling of proxy-revalidate cache directive and handling of max-stale without specified limit

Answer 1 · 2017-01-10T23:00:12.000Z

cc @muratg

Answer 2 · 2017-01-19T18:28:50.000Z

This patch bug is approved. Please use the normal code review process w/ a PR and make sure the fix is in the correct branch, then close the bug and mark it as done.

Answer 3 · 2017-01-19T18:28:54.000Z

@muratg please assign.

Answer 4 · 2017-01-23T22:15:49.000Z

Patch merged. Leaving the issue open since version numbers will need to be updated.

Answer 5 · 2017-02-15T01:41:47.000Z

Changes merged. Updating version numbers now.