Rewrite HttpClientSlimTests in a way that doesn't depend on Hosting

Question

Rewrite HttpClientSlimTests in a way that doesn't depend on Hosting

cesarblum opened this issue 8 years ago · 7 comments

cesarblum commented 8 years ago

Removed in 28fee6a because it broke the CI:

http://aspnetci/viewLog.html?buildId=249845&buildTypeId=UniverseCoherence&tab=buildLog#_focus=975

Answer 1 · 2017-08-16T16:50:38.000Z

@javiercn can you take a look?

Answer 2 · 2017-08-16T18:03:05.000Z

@CesarBS can you describe what the issue here is and what the expectations/goals are?

Answer 3 · 2017-08-16T18:03:24.000Z

How it broke the CI and what does in your opinion need to change

Answer 4 · 2017-08-21T23:41:25.000Z

I thought CI links would live forever 😢

Those tests broke the CI when moved here because they created a cycle in the dependency graph (Testing -> Hosting -> Testing IIRC).

I created this issue so this wouldn't get lost, but I'm not sure it's worth putting much effort into this. HttpClientSlim is transitively tested wherever it's used. BTW that's only Kestrel now, but it was used in MetaPackages for a while (in functional tests that used HTTPS).

Answer 5 · 2017-08-22T03:52:08.000Z

So can this be closed then?

Answer 6 · 2017-08-23T21:47:43.000Z

It hadn't occurred to me before to use HttpListener as the server for those tests. You can look into that, but you can assign the bug to me as well since I was the one who moved HttpClientSlim here and subsequently removed its tests.

Answer 7 · 2017-08-23T23:01:28.000Z

@CesarBS Ok. I will do so.