aspnet/jquery-validation-unobtrusive

Missing dist folder again #1877

wolfkumpitsch1 opened this issue · 13 comments

wolfkumpitsch1 commented

breaking PROD version
dist folder added to ignore in .gitignore

is this going to be the future default?

mkArtakMSFT commented

Thanks for contacting us, @wolfkumpitsch1.
@ryanbrandenburg, what was the motivation for ignoring dist folder?

Eilon commented

We removed it because the idea was that running build (or whatever) will produce it. We don't check in build outputs into the repo, only the "source code."

But I warned this might break something!

Having said that, @wolfkumpitsch1 , can you provide info on what you were doing and how you saw an error?

Eilon commented

This was the PR that removed it: #99

wolfkumpitsch1 commented
ryanbrandenburg commented

@wolfkumpitsch1 I think we're asking more like how are you acquiring and using the package. IE, npm, git, nuget etc.

wolfkumpitsch1 commented
Eilon commented

Hi @wolfkumpitsch1 , Bower is unfortunately no longer supported by us and we recommend using an alternative such as NPM to acquire static assets such as this project.

mkArtakMSFT commented

@wolfkumpitsch1, we still don't understand what you're having trouble with. Please provide a repo in GitHub that demonstrates your problem, so we can investigate it.

danroth27 commented

After chatting with @javiercn it sounds like Bower in particular expects that the repo contains a dist folder with the production files (i.e. minified), so removing this folder from the repo broke Bower scenarios. That said, you may be able to point to an earlier tagged version that still has the dist folder (ex https://github.com/aspnet/jquery-validation-unobtrusive/tree/v3.2.10).

danroth27 commented

@wolfkumpitsch1 Can you switch to using npm directly instead?

Eilon commented

Right, breaking Bower was an explicit decision that was made, so that was deliberate.

wolfkumpitsch1 commented
ryanbrandenburg commented

Sounds like you have this under control then. Closing.