Most of the dependencies are actually devDependencies
lassesteffen opened this issue · 1 comments
lassesteffen commented
Problem
@types/jest
and @types/mocha
clash with their type definitions. This is usually not a problem since people can decide which one to install. Since I rely on this package I now have @types/mocha
in my packages which I didn't need to have there before.
"devDependencies": {
"request-debug": "^0.2.0",
"typescript": "^3.6.3"
},
"dependencies": {
"@types/chai": "^4.2.3",
"@types/mocha": "^7.0.2",
"@types/request": "^2.48.3",
"chai": "^4.2.0",
"mocha": "^7.1.1",
"request": "^2.88.0",
"superagent": "^3.8.3",
"ts-node": "^8.4.1"
}
Solution
Since most of the dependencies are actually development dependencies, the dependencies should rather look like this
"devDependencies": {
"@types/chai": "^4.2.3",
"@types/mocha": "^7.0.2",
"@types/request": "^2.48.3",
"chai": "^4.2.0",
"mocha": "^7.1.1",
"request-debug": "^0.2.0",
"ts-node": "^8.4.1",
"typescript": "^3.6.3"
},
"dependencies": {
"request": "^2.88.0",
"superagent": "^3.8.3"
}
request
and superagent
are the only production packages and should stay where they are
IvanAndreychikov commented
Thanks for finding this issue! I have moved mentioned dependencies to the devDependencies.