assemble/grunt-assemble

support for assemble 0.7.x

Opened this issue · 9 comments

grouchal commented

Any idea when this is coming

assemblebot commented

@grouchal Thanks for the issue! If you're reporting a bug, please be sure to include:

  • The version of assemble you are using.
  • Your assemblefile.js (This can be in a gist)
  • The commandline output. (Screenshot or gist is fine)
  • What you expected to happen instead.
ashleynolan commented

+1 on this.

I use Assemble on both Grunt and Gulp projects, and would like to keep them in sync if possible (having already moved onto 0.7 by using Assemble direct with Gulp).

Any idea when this is likely to be updated?

jonschlinkert commented

Any idea when this is likely to be updated?

already started work on it. Not sure how long it will take, I'll let you know as soon as I or @doowb make more progress

ashleynolan commented

Great – thanks for the update 👍

witrin commented

@jonschlinkert Any news here? Would love to see an update for Grunt.

witrin commented

@jonschlinkert Thanks! I've seen it already. When will you release it?

witrin commented

@jonschlinkert I've used your latest develop (https://codeload.github.com/assemble/grunt-assemble/tar.gz/a824b27eba5f00797452cf03854911e50e457694) but renderFile in https://github.com/assemble/grunt-assemble/blob/refactor/tasks/assemble.js#L84 returns an DestroyableTransform with writecb equals null. The exception is obviously Fatal error: no writecb in Transform class. Any idea what's the problem here?

Also the interactive question "engine-handlebars" must be installed. Want to do that before continuing? when starting this the first time is problematic if this is executed by a build system. Is it possible to include this in the package.json?

jonschlinkert commented

Is it possible to include this in the package.json?

Since assemble v0.6.0 and up can run any engine, it wouldn't make sense to add any particular engine as a dep. We should probably just remove the prompt and throw an error.

Fwiw, I personally thought the prompt was a nice experience, it worked well for me - we also do something similar with gulp and generate. But I can see how it might be hard to make it work well consistently.

In any case it's pretty easy to add engines:

// where `hbs` is the file extension to match
app.engine('hbs', require('engine-handlebars'));