asset-pipe/asset-pipe-build-server

Set `process.env.NODE_ENV = 'production'` when bundling

Opened this issue · 11 comments

SimenB commented

Currently we get the development version of e.g. react in production. Would be nice to avoid that

trygve-lie commented

Is there other ways to tell react to provide prod version than using process.env.NODE_ENV?

vue.js will btw have the same issue.

sveisvei commented

I think it makes sense to inject NODE_ENV from the server process.env.

SimenB commented

Sorta related: we don't do minification

SimenB commented

@digitalsadhu this is done now, right?

digitalsadhu commented

Minification based on NODE_ENV=production yes.
We didn't end up including envify yet though so still need to revisit that.

SimenB commented

ah, of course.

digitalsadhu commented

We now support minification. Defaults to process.env.NODE_ENV with fallback to 'development' if not defined. Latest client also allows overriding this on any given client call.

theneva commented

market-frontpage on Podium v2 says this:

image

Looks like we still have a ways to to here

digitalsadhu commented

Wonder what’s up here.
Envify in use here:
https://github.com/asset-pipe/asset-pipe-js-reader/blob/742677c33284069c60f243334337d57a836417d6/lib/reader.js#L74

And I’ve seen this work with react.

theneva commented

Yep, I went digging and couldn't find anything obvious. Will have to continue looking into it tomorrow.