assetgraph/assetgraph-sprite

Sprite instructions don't get removed from the CSS

Munter opened this issue · 2 comments

When building sprites so far these two vendor specific selectors, which are only there for assetgraph-sprite, don't get removed from the resulting CSS:

-one-allow-selector-merge:true;
-one-sprite-selector:.icon;

We might want to kill every property starting with -one- before outputting to production.

(Argh, why don't I get notified when a new issue is created?)

Those are artifacts from the old pre-node.js build system we used. I dropped -one-allow-selector-merge because it was too ugly and unpredictable. -one-sprite-selector was cut because it was actually redundant. Now, instead of having both -one-sprite-selector: cssSelector and -one-sprite-group: groupName pointers in each selector containing an image, there's only -one-sprite-group: groupName and a single -one-selector-for-group: groupName marker in the group selector.

AssetGraph-sprite only cleans up the custom properties it actually supports. The fact that you opened this issue kinda proves that to be a good decision :).

I wrote a little README yesterday, hopefully it's now clearer what the supported options are.

Nice. The documentation really helps a lot :)