go-astilectron always provisions same version of Electron even when different VersionElectron is set
Closed this issue · 2 comments
RoaringTwenties commented
I've integrated go-astilectron (latest release, v0.18.0) with my app. I'd like to use a newer version of Electron instead of what go-astilectron fetches by default.
I'm using the following code to create a new Astilectron instance:
a, err := astilectron.New(l, astilectron.Options{
AppName: "Test App",
BaseDirectoryPath: "resources",
VersionElectron: "9.3.0",
VersionAstilectron: "0.41.0",
})No matter what, go-astilectron always provisions the same version of Electron (v.7.1.10). Am I possibly missing something?
Another question: if possible, could the README be updated to clarify the latest version of Electron go-astilectron has been tested/known to be compatible with?
Thank you!
asticode commented
When I run the example with your options updated here it works properly :
2020/10/02 15:37:25 astikit: starting worker...
2020/10/02 15:37:25 Starting...
2020/10/02 15:37:25 Provisioning...
2020/10/02 15:37:25 Provisioning Astilectron...
2020/10/02 15:37:25 Removing directory /Users/asticode/projects/go/src/github.com/asticode/go-astilectron/example/vendor/astilectron
2020/10/02 15:37:25 Downloading https://github.com/asticode/astilectron/archive/v0.41.0.zip into /Users/asticode/projects/go/src/github.com/asticode/go-astilectron/example/vendor/astilectron-v0.41.0.zip
2020/10/02 15:37:25 astikit: sending GET request to https://github.com/asticode/astilectron/archive/v0.41.0.zip (1/1)
2020/10/02 15:37:25 Creating directory /Users/asticode/projects/go/src/github.com/asticode/go-astilectron/example/vendor/astilectron
2020/10/02 15:37:25 Unzipping /Users/asticode/projects/go/src/github.com/asticode/go-astilectron/example/vendor/astilectron-v0.41.0.zip/astilectron-0.41.0 into /Users/asticode/projects/go/src/github.com/asticode/go-astilectron/example/vendor/astilectron
2020/10/02 15:37:25 Provisioning Electron...
2020/10/02 15:37:25 Removing directory /Users/asticode/projects/go/src/github.com/asticode/go-astilectron/example/vendor/electron-darwin-amd64
2020/10/02 15:37:25 Downloading https://github.com/electron/electron/releases/download/v9.3.0/electron-v9.3.0-darwin-x64.zip into /Users/asticode/projects/go/src/github.com/asticode/go-astilectron/example/vendor/electron-darwin-amd64-v9.3.0.zip
2020/10/02 15:37:25 astikit: sending GET request to https://github.com/electron/electron/releases/download/v9.3.0/electron-v9.3.0-darwin-x64.zip (1/1)
2020/10/02 15:37:30 Creating directory /Users/asticode/projects/go/src/github.com/asticode/go-astilectron/example/vendor/electron-darwin-amd64
2020/10/02 15:37:30 Unzipping /Users/asticode/projects/go/src/github.com/asticode/go-astilectron/example/vendor/electron-darwin-amd64-v9.3.0.zip into /Users/asticode/projects/go/src/github.com/asticode/go-astilectron/example/vendor/electron-darwin-amd64
2020/10/02 15:37:32 Finishing provisioning electron for darwin system
Can you share more of your code and the exact output logs ?
Also, can you confirm you're not using the bundler ?