Issues in the addon comms code

[Numynum]

hi, I was reverse engineering your addon comms, for an addon that emulates keystone addon comms for people who don't want to install Astral Keys and similar (or rather, so I can still see their keys in my AK list :p)

I noticed a few things that I figured would be worth sharing, keeping in mind that I might be mistaken about some things 🙂

https://github.com/astralguild/AstralKeys/blob/main/Lists/Friends.lua#L282 ends up sending SYNC messages to both BNet and nonBNet friends, the issue is that the code builds messages of up to 2000 characters, which is way too large for nonBNet whisper comms
I didn't test it, but I assume the result, is that if you have enough alts to fill more than 255 characters, your nonBNet friend will not receive the sync message, and not see your alts on their friend list

https://github.com/astralguild/AstralKeys/blob/main/Lists/Guild.lua#L185 also about SYNC messages, but this one is easier to reproduce
the messageStack gets merged into messages of up to 235 characters, but the final trailing message(s) is never sent.
This results in some characters not being updated, or simply not showing up on the guild list of your guildies
I reproduced this by having 2 accounts with 1 character each on PTR, when opening AK window, I could only see my own character's keys, until an UPDATE message comes in

and finally the issue in #113, no WHISPER comms messages are being sent at all to nonBNet friends, which means they'll never show up on the friend list

these issues don't seem to have a big impact, otherwise more people surely would've noticed, and frankly, I didn't really notice myself until I started digging into the code; so do with this info what you will, I just wanted to mention it anyway 🙂

thanks for the addon, and keep up the good work 😎