Any plans to make new release?
kloczek opened this issue · 16 comments
Last release was quite long time ago and there are few critical fixes added on top of that last release.
I think that it would be good to make new one :)
Thx
There is already some demand for new release in community: please refer to naelstrof/maim#260
I hope that the author, @astrand, is still around and will be able to get to this. While technically I could issue a new release, it would be disrespectful to the author to do it without consultation.
Unfortunately, I don't use the mainline xclip anymore as I've been happy with my own. I also haven't looked at any of the proposed fixes, so I don't even know which pull requests are most important. Could you please list for me the PRs that you consider critical in a new release? Or is the mainline code good enough?
Sadly I don't use xclip anymore and I cannot really give any valuable feedback since I didn't have any issues with 0.13 back in time. Though I assume mainline is good enough? We should probably test if it works well in different distros and then make a release. If you want to go for manual testing I will happily volunteer :^)
Yes, manual testing would be good. I'm installing the mainline xclip as well, but the more eyes the better. (By the way, may I ask what you use as a replacement for xclip and why you switched if 0.13 worked for you?)
may I ask what you use as a replacement for xclip
the simple and obvious answer is wl-copy and wl-paste =)
IIRC one cannot use xclip in Wayland session.
Yes, manual testing would be good.
I have performed some manual testing and I can confirm that xclip compiles, copies to PRIMARY and CLIPBOARD, copies and pastes images and outputs PRIMARY to stdout successfully on following distros:
- archlinux installed with archinstall, choosed GNOME desktop environment;
- archlinux installed with archinstall, choosed KDE desktop environment;
- Ubuntu 22.10;
- Fedora 37.
FYI: list of changes added to xclip on top of 0.13 release:
[foxpy@t14s xclip]$ git log --oneline 0.13..master | cat
b372f73 Fix uninitialized variables causing segfault
faeebf2 Merge pull request #130 from a1346054/fixes
31451a4 Trim trailing whitespace
1280975 Cleanup test script
6eba137 Fix spelling
b26e712 Use license file from gnu.org
11cba61 Merge pull request #104 from hwangcc23/minor-fix-res-leak
ccfd9a0 Fix resource leak
5f6b8fb Merge change to default to -o (output mode) when stdin is a tty.
8773241 Merge branch 'sensiblestdin' of https://github.com/hackerb9/xclip into hackerb9-sensiblestdin
4601354 Merge pull request #86 from astrand/xcfetchname_and_xerror
35866c8 Use xcnamestr for more succinct code
33dc754 ICCCM 2.1 says XSetSelectionOwner may "merely appear to succeed"
66700a2 try multiple sizes of binary data, up to 16MB
786fd4a When losing selection, print name of new owner
5cb0785 replace calls printing ID number with xcnamestr
6c739dd Add xcnamestr convenience function
a66a5e3 Squashed commit of XError and Debugging Branch
4a3b58c Print deletion of "requestor" when debugging
c9b411d Use evtstr table of X event types for -debug mode
0345a0d Use a switch statement for clarity
b4ecd4d xcfetchname now finds any window, not just selection owner
18fd73c Debug prints windowname selection requests are from
0eec3eb xcfetchname() is more generally useful, particularly for debugging, so move it out of xcprint.c and into xclib.c.
84f96a2 Merge tree implementing debug verbosity
242c437 xcverb's output level constants should be defined in xclib.h
30bfe61 Add xcverb global for verbosity level
ca27739 Change fverb to xcverb and add -debug option
4cc76a7 Add an fverb level higher than OVERBOSE: ODEBUG
874f2a2 Verbose messages should also be printed out when debugging
24b4d30 no busy loop when intentionlly hanging
cdd523e Force -lX11 and -lXmu for LDFLAGS.
9d0d7a7 Add borked.c for testing anomalous events
14ab9c6 -verbose should include printing out losing the selection & requestors.
f309299 When pasting, don't clear selection unless -sensitive is given
fc09ba6 Merge branch 'testing-fix-filter'
e7e177d Fit help text to 80 columns
e1067e6 Merge branch 'fix-filter' of https://github.com/hwangcc23/xclip into testing-fix-filter
898c953 Merge pull request #85 from astrand/testing-sensitive
82853ed Cleanup -help to fit 80 column screen width
290a378 Clarity cleanup of -wait
1b02a61 White space fix up
25ba218 Restoring proper errconvsel() behavior
da7becf Remerged errconvsel behavior
70b2da6 Changed return type of errconvsel()
ae168bc Remerging changes to xcprint.c
240e321 Changes to handling sensitive data
9344507 Merge pull request #83 from astrand/testing-revised-error
3789577 Use errconvsel() to print error messages and exit
8bc788d On conversion error, print window name of selection owner instead of cryptic ID
1551479 Merge branch 'fix-38' of https://github.com/hwangcc23/xclip into testing-revised-error
2b08be5 Help other contributors keep consistent indentation
2a857d3 Clean up whitespace and reword -secure description
a2590e9 minor whitespace cleanup
86b93b4 Hopefully more clear explanation of -secure
03d5f82 Merge pull request #70 from kennbr34/secure-mode
b95a8e7 Merge branch 'master' into secure-mode
b3c4033 Update xclip.c
8d10aec Make xclip exit when it loses the selection (#71)
1eae4fe Reverted back to the original loop counter method
9f20d19 Implemented Rik Snel's -wait patch instead of -loops 1
50df9e0 Changed how dloop is incremented so that -loops 1 actually pastes once to all kinds of windows
fb0501a Fixed compiler warnings
a21e11b Added -secure mode to wipe selection buffers and clear selection after single paste
9d754b3 Undo all changes to documentation.
6ceb59e Undo convenience options -T and -c
078932d Update with several patches.
040c6af Fix -loops failure with large-data-transfers (#60)
6623ccd Fix the problem for large buffers (#57)
3028882 Revise error messages
efd6dd0 Fix -filter affected by -rmlastnl
57c8afe Add the -filter opion on the output of -help
b161f2c Prepend rm arguments with -- in xclip-cutfile (#44)
6a318f3 Fix typos (#49)
6026cee Update INSTALL with needed Ubuntu deps (as example) (#46)
08a5ed8 Corrected URL to Freedesktop clipboard spec
26c8499 Merge pull request #41 from botovq/master
40fdadc Avoid printf "%s" NULL
f6ef08a Merge pull request #40 from EdwardBetts/spelling
4cf54b8 Correct spelling mistakes.
9e13102 Merge pull request #29 from czarkoff/tar
db74a39 Add "-f -" flags to tar
[foxpy@t14s xclip]$
Thank you for all that testing! I have been trying the mainline xclip with Xwayland and it seems to work fine for me, but maybe I'm not running any native Wayland apps. I seem to recall there was some talk about using the clipboard by default since Wayland didn't know about the primary selection. Would that solve the issue for you?
Thanks also for the list of changes you think should be included. Just to double check: there are no obvious release critical bugs in the current master?
I seem to recall there was some talk about using the clipboard by default since Wayland didn't know about the primary selection. Would that solve the issue for you?
🤔 I don't actually have any issues, I just know there is some demand in community for new xclip release.
Talking about Wayland, I don't see any point in testing xclip with it since there are wl-copy and wl-paste utilities which work great under Wayland anyway. xclip is designed for X11, let's test it just under X11.
Just to double check: there are no obvious release critical bugs in the current master?
I hope there aren't any, at least I haven't heard anything about them. Don't worry too much, I am 100% sure distro maintainers will report any problems (if there are any) during their testing stage before shipping xclip in their stable repositories. I have bothered to test xclip manually in some distros just to filter out obvious pitfalls.
I agree about testing under X11. I just forgot that my new laptop came with Wayland by default and was pleasantly surprised that xclip worked fine with Xwayland. Which I guess makes sense since technically it is an X11 server.
After refreshing my memory of the code, there were some outstanding bugs that I had squashed long ago in my own branch but that never got pulled in. You shouldn't notice any difference as it mostly just added error handling, but if you'd like to give it a shot, I put it in the branch called 'pre-0.14'.
@astrand Could you please try the pre-0.14 branch? I don't think it has noticeable changes compared to the current master, other than that xctest now works.
You shouldn't notice any difference
Yep, seems to work fine, though I didn't test it as extensively (not if it is reall required this time).
@astrand Pre-0.14 has been working fine for me for over a month, so I've made a pull request. Please check it over and accept the pull into the master branch. After that, we can turn it into the new stable release.
Hi @hackerb9, PR looks fine. Do you want me to merge it, if so, Squash or normal commit?
@astrand Pre-0.14 has been working fine for me for over a month, so I've made a pull request. Please check it over and accept the pull into the master branch. After that, we can turn it into the new stable release.
Can I have your pre release please?