ExtractOutputPreprocessor isn't being used by nbcollection?
jonathansick opened this issue · 2 comments
In #530 we enabled the ExtractOutputPreprocessor (which extracts figures from html files, thereby making them something that the UI can source in the cards). However, this doesn't seem to actually be running. If you look at any rendered-tutorials artifact, the figures are definitely still embedded.
Are traits not getting passed by nbcollection to nbconvert? Any ideas @adrn?
Now, we can work around this by having Learn Astropy Librarian extract the figures and put them on some static file host (while doing some sort of resizing and optimization... which we may need to do regardless), however, it'd be good to understand what's going on here.
Hm, not sure! I can look into this next week
I think this commit will fix the issue: astropy/nbcollection@a1101ef