astuder/lightroom-map-fix

Problem with patch for LR 7.5

williwkl opened this issue · 4 comments

williwkl commented

I am using the patchluastr as exe but it only workes with LOCATIONMAPVIEW.LUA:

Processing LOCATIONMAPVIEW.LUA
Lua 5.1 detected
Lua settings: endian 1, int 4, size_t 8, instruction 4, number 4
118933 bytes read from file
Found 'client=gme-adobesystems' at 10424
Found 'client=gme-adobesystems' at 21086
Updated 2 strings
118973 bytes written to LOCATIONMAPVIEW.bin

When I want to patch AGREVERSEGEOCODESERVICE.LUA I get:

Processing AGREVERSEGEOCODESERVICE.LUA
Lua 5.1 detected
Lua settings: endian 1, int 4, size_t 8, instruction 4, number 4
14155 bytes read from file
'client=gme-adobesystems' not found, nothing to patch
Traceback (most recent call last):
File "patchluastr.py", line 133, in
NameError: name 'exit' is not defined
[10936] Failed to execute script patchluastr

Updating the LR map module with only the LOCATIONMAPVIEW.bin file I see the map for a fraction of a second and then the usual LR maps error message.

What can I do else?

astuder commented

Hi Willi,

I don't know if this hack will work with Lightroom CC. The error message about exit is a bug, but before that it says that Adobe's key wasn't found in the AGREVERSEGEOCODESERVICE.LUA. Obviously, Adobe changed something compared to Lightroom 6..

If you email me the LUA file I can take a look. See my profile for the email address.

jbd7 commented

The patch probably fails because for CC 7.5, AGREVERSEGEOCODESERVICE.LUA uses https://api.mapbox.com/ and not Google.
I tried updating Location.lrmodule with only LOCATIONMAPVIEW patched, and with AGREVERSEGEOCODESERVICE from LR 6patched, but it would not work, as mentioned by williwkl.

Note that the error message in LR CC 7 is different (https://helpx.adobe.com/lightroom/kb/map-view-no-longer-supported.html) and looks like a different handling of the end of support.

astuder commented

I think this is related to issue #8 and LR7 calls home.

jbd7 commented

You're right, it does call photoshop.com

Following your advice on the other issue, with CC 7.5, I tried to quickly replace google-map in the API call to by google-mop (that call returns an OK response) in AGREVERSEGEOCODESERVICE.LUA and LOCATIONVIEWCONTROLLER.LUA, editing these files as hex, and it made the Map Module load correctly.

It displays geotagged photos as expected, however, dropping a non geotagged photo onto the map doesn't assign GPS coordinates to it.