asyncapi/jasyncapi

Set to true/false the property additionalProperties in Schema class

tmoreno opened this issue · 7 comments

Description

According to examples found in modelina project, the property "additionalProperties" can be: true, false or a map, but jasyncapi only admit Schema objects. Please see this example (or any other):

https://github.com/asyncapi/modelina/blob/master/test/blackbox/docs/JsonSchemaDraft-7/asyncapi-2_0.json

In the spec reference page, this property is not documented.

I would like to be able to set this property to true or false, because java classes generated by modelina are affected by this property.

This is an extract from documentation (https://github.com/asyncapi/modelina/blob/master/docs/interpretation_of_JSON_Schema.md):

additionalProperties are interpreted as is, where duplicate additionalProperties for the model are merged. If the schema does not define additionalProperties it defaults to true schema.

Welcome to AsyncAPI. Thanks a lot for reporting your first issue. Please check out our contributors guide and the instructions about a basic recommended setup useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

This issue has been automatically marked as stale because it has not had recent activity 😴

It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation.

There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here.

Thank you for your patience ❤️

This issue has been automatically marked as stale because it has not had recent activity 😴

It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation.

There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here.

Thank you for your patience ❤️

wouldn't this is the case in apicurio data model?

I have added a StackOverflow question and an issue in apicurio also, just want to confirm this is the scenario

https://stackoverflow.com/questions/75802008/asyncapi-apicurio-data-model-additionapropertiestrue

@Pakisan

@tmoreno hi!

Check out this merged pr. We double checked correctness of changes - additionalProperties can be boolean or Schema
#131

wouldn't this is the case in apicurio data model?

Will check it as soon as possible. The answer, for now, is I don't know because folks from Red Hat are using their own way to handle AsyncAPI specification