asyncapi/protobuf-schema-parser

Consider upgrading the code to be supported by AsyncAPI Parser-JS v2

smoya opened this issue · 4 comments

smoya commented

Reason/Context

Parser-JS 2.0 (released as rc at this moment) is a completely new parser, with a lot of changes. The bigger ones are:

  • Completely rewritten to TS.
  • Implements the new parser-api, in particular, the version found in this PR.
  • Uses Spectral as parser/linter with the AsyncAPI ruleset.
  • Lots of other improvements, especially around Developer Experience.

Considering that Spectral now validates the documents before parsing, we had to update the interface for Schema parsers to separate validation from parsing. This change also introduced better errors and the way we handle them. (see this issue and related).

Description

Note that Parser-JS v2 uses TypeScript so feel free to use it as well.

Welcome to AsyncAPI. Thanks a lot for reporting your first issue. Please check out our contributors guide and the instructions about a basic recommended setup useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

parser-js 2.1.0 is already supported.
PR for integration in react component is open: asyncapi/asyncapi-react#758

Or do i miss something to do?

smoya commented

Yeah, I just was moving the issue from GreenRover/proto-schema-parser#2 to here without even checking. Can be closed.

smoya commented

@GreenRover I created two crucial issues I consider should be done asap if we want to let people adopt the new protobuf schema format: