asyncapi/website

[BUG] adopters.json data file is not updated

Closed this issue · 8 comments

sambhavgupta0705 commented

Describe the bug.

So basically we first add data in adopters.yml file and then it gets updated in adopters.json file but the last time when the data was updated in yml file the json file wasn't updated.

Expected behavior

adopters.json should also get updated as on each and every commit by anyone the file gets updated

👀 Have you checked for similar open issues?

  • I checked and didn't find similar issue

🏢 Have you read the Contributing Guidelines?

Are you willing to work on this issue ?

No, someone else can work on it

akkshitgupta commented

Hey @sambhavgupta0705, I have already worked with yaml file in previous PR. Also, the task can be achieved using a CI workflow, which gets triggered whenever the particular file is changed in a pull request. I would like to solve this particular issue :)

sambhavgupta0705 commented

Yeah we can think of CI workflow for this
What are your thoughts on this @akshatnema @anshgoyalevil @derberg

akshatnema commented

Yeah, updating it via workflow is a good solution. We can add the updation steps in existing workflow of newsroom and meetings, or we can do it weekly by adding it in tools workflow, depending upon how we want to update it.

sambhavgupta0705 commented

Well I think the Yaml is being updated manually so I think we should update the json file weekly but I have one doubt that the adopters.json file is present in .gitignore so will it create any problem

akkshitgupta commented

Any updates? I would like to solve the bug :)

CC: @sambhavgupta0705 @akshatnema

akshatnema commented

@akkshitgupta Yeah, you can work on this issue.

  • 👍1
akkshitgupta commented

@akshatnema @sambhavgupta0705, Since the adopters.yml file is updated with the new Adopters of AsyncAPI with a new pull request. Would it not be a good idea to trigger the workflow whenever there is a change in the file specifically rather than executing the task repeatedly every day without having even a single change in the already existing adopters.[json/yml] file.

sambhavgupta0705 commented

@akkshitgupta we don't need adopters.json file as it is a build time file and it is not required to have that in the master codebase that is being handled automatically during the build time

  • 😄1