athityakumar/colorls

colorls -h shows help

heitorpolidoro opened this issue · 2 comments

heitorpolidoro commented

Description

Thanks for opening this issue. Add a brief description of what this issue is, and how to recreate it. Do tag the relevant issue(s) and PR(s) below. If required, add some screenshot(s) to showcase the issue.

  • Relevant Issues : (none)
  • Relevant PRs : (none)
  • Type of issue :
    • Installation
    • Font-related
    • Feature request
    • Bug in existing feature
    • Developer mode : Code quality / Tests / Documentation

When I run colorls -h shows the help (same if I run colorls --help) instead the flag --human-readable

t-mangoe commented

I think this behavior seems to be a specification.
If the argument is only -h, colorls shows the help.

colorls/lib/colorls/flags.rb

Lines 314 to 315 in 24e402c

# show help and exit if the only argument is -h
show_help if !@args.empty? && @args.all?('-h')

avdv commented

Yes, this works as designed. ls -h showing the help was done for backward-compatibility. The -h/--human-readable flag was added later for GNU ls compatibility and has no effect for colorls (file sizes are always shown human readable) -- this is stated in the help text.