atj/userscripts

mb_spotify_isrc_link: wildcard in protocol doesn't work in Greasemonkey

ToadKing opened this issue · 2 comments

On Greasemonkey for Firefox, installing the Spotify ISRC link script fails with the following error:

Ignoring @match pattern http*://*.musicbrainz.org/release/* because: Error: @match: Invalid protocol (http*:) specified.

Manually adding two patters, one for http and one for https, allows it to install.

atj commented

Sorry about the lack of response to this @ToadKing. For some reason I wasn't watching this repository and so I didn't notice you'd filed an issue. Thanks for taking the time, it is appreciated.

The PR from @jesus2099 that will be merge shortly should resolve this issue.

Good spot, @ToadKing, //@ match http*:// is invalid syntax anyway, //@ match *:// should be used per specs:

If the scheme [protocol] is *, then it matches either http or https, and not file, or ftp.

Oh we wrote at the same time. :)