atmoschem/vein

Issues with the upcoming release of units 0.8-0

Enchufa2 opened this issue · 5 comments

Enchufa2 commented

Dear maintainer,

We are preparing units 0.8-0 for release in approximately a month. I'm writing to you because our revdep checks report new issues in your package with this new version (you can check them here).

These issues seem to be caused by an incorrect comparison of units and numeric vectors using all.equal() (or expect_equal(), which uses the former). The new version of units includes a fix in the all.equal.units() method that (correctly) triggers these errors.

To address this, I suggest to either drop the units of the first member of such comparisons, or to promote the second member to a units object with proper units.

edzer commented

submitting units to CRAN is planned to happen soon.

ibarraespinosa commented

@Enchufa2 and @edzer , many thanks for letting me know. I will update units and fix all possible problems. Many thanks

ibarraespinosa commented

Hi @Enchufa2 and @edzer I was travelling in Chile without a laptop and just yesterday saw this email. vein is updated here 79202c0

edzer commented

OK, great - pls note that it's broken on CRAN right now: https://cran.r-project.org/web/checks/check_results_vein.html

ibarraespinosa commented