atom-community/atom

Fix the failing path watching Windows tests caused by Windows 2019

aminya opened this issue · 0 comments

Description

After switching to Windows 2019 in #408, some of our tests have started to fail. We should debug the issues and fix them. I suspect this is because Windows 2019 ships with a new Visual Studio C++ compiler and newer C++ standards by default.

Steps to Reproduce

See https://dev.azure.com/atomcommunity/atomcommunity/_build/results?buildId=1330&view=logs&jobId=f28c492c-c33f-521e-c0ca-e4634e70a589&j=f28c492c-c33f-521e-c0ca-e4634e70a589&t=a1ca5d4d-dde3-5878-7fb1-f5040f2451be

Expected behavior:

Actual behavior:

watchPath
  watchPath()
    it watchPath watchPath() reuses an existing native watcher on a parent directory and filters events
      timeout: timed out after 120000 msec waiting for spec promise to resolve
    it watchPath watchPath() adopts existing child watchers and filters events appropriately to them
      timeout: timed out after 120000 msec waiting for spec promise to resolve
Project
  .onDidChangeFiles()
    it Project .onDidChangeFiles() reports filesystem changes within project paths
      Error: Expired before all expected events were delivered.
        at expire (D:\a\1\s\spec\project-spec.js:1077:13)

Reproduces how often:

Always

Versions

Dev

Additional Information