[REFACTORING] Complete rewriting
vivi90 opened this issue · 15 comments
The code needs to be completely rewritten, because it's too old.
@UziTech I have started rewriting it, but i am not able to get it working.
Something with the serialization might be wrong but i have no idea, how to solve it, so i am not able to continue.
So i have pushed it to: https://github.com/atom-extensions/dec-hex-oct-bin/tree/WIP-6
Whenever I have moved from coffeescript to js I use https://decaffeinate-project.org/repl/ to translate it then clean up the code.
This seems to work as is. What exactly isn't working?
I see. it looks like the issue is you are not saving the view to this.view when deserializing
I fixed it in 7ff83d7
@UziTech In https://github.com/atom-extensions/atom-music/blob/master/lib/atom-music.js it's also not saved to this.atomMusicView, when it deserializes. So i don't understand the issue.
Nevertheless, thank you very much! 🙂
I will test it later.
hmm that is strange. I'm not sure why that works.
It looks like serialization wasn't working in atom-music. atom-extensions/atom-music#36 should fix it
@UziTech No, serialization works, because the playlist doesn't disappears. At least in my Atom.
when you refresh atom the playlist stays?
I meant reload Atom. If you open atom music in the bottom dock then close atom, the next time you open atom atom-music should be opened in the bottom dock without needing to "toggle" it.
serialization is for Atom to save the state across reloads and automatically resume the view when Atom starts. With my PR atom-extensions/atom-music#36 it should be working for atom-music
@UziTech Yes, i know. But why it resumes the content of the view (the playlist) successfully, also if the serialization is broken?
(Just try to understand Atom in a better way, because the manual is not so great.)
Yes, i will check your PR soon.
The release is available on:
Your semantic-release bot 📦🚀