atom/atom-keymap

Problem with polish (programmer) keyboard

Closed this issue · 13 comments

RoboWeb commented

Hi! After update Atom to v. 1.12.4 and deprecation package "keyboard-localisation" - polish keyboard localisation dsn't work. I have MSWin10 O.S.. More specifically - in Editor:
AltGr+a, and AltGr+A | Expectation: "ą" and "Ą" | in Atom "ą", "Ą" - OK
AltGr+c | Expectation: "ć" | in Atom "ć" - OK
AltGr+C | Expectation: "Ć" | in Atom "" - no reaction
AltGr+e, AltGr+E | Exp: "ę", "Ę" | Atom: "ę", "Ę" - OK
AltGr+l, AltGr+L | Exp: "ł", "Ł" | Atom: "ł", "Ł" - OK
AltGr+n, AltGr+N | Exp: "ń", "Ń" | Atom: "ń", "Ń" - OK
AltGr+o | Exp: "ó" | Atom: "Open Folder" - (so it also works AltGr+Ctrl+o = "Open Folder")
AltGr+O | Exp: "Ó" | Atom "Ó" - OK
AltGr+s, AltGr+S | Exp: "ś", "Ś" | Atom: "ś", "Ś" - OK
AltGr+z | Exp: "ż" | Atom: "Confirm Checkout HEAD revision" (AltGr+Ctrl+z)
AltGr+Z | Exp: "Ż" | Atom: "Ż" - OK
AltGr+x, AltGr+X | Exp: "ź", "Ź" | Atom: "ź", "Ź" - OK

Summary:
AltGr+C - no reaction
AltGr+o - "Open Folder", (should be only AltGr+Ctrl+o)
AltGr+z - "Confirm Checkout HEAD revision"

(hmmm... :) - not bad... but I need this letters/chars :)
img with polish programmer keyboard localisation:
pl-programmers

Ben3eeE commented

For AltGr+o and AltGr+z and Atom 1.12 this is expected. The keys are bound to editor:checkout-head-revision and application:add-project-folder. These keybindings are removed or moved in Atom 1.13. We did not want to change this in a hotfix release of Atom 1.12.

So your solution is to either unset these keybindings in Atom 1.12 or to run Atom beta. To unset the keybindings add the following to your keymap.cson which you can reach from the file menu. File -> Keymap...

'atom-workspace atom-text-editor:not([mini])':
  'ctrl-alt-z': 'unset!'
 
'body':
  'ctrl-alt-o': 'unset!'

For AltGr+c can you open the keybinding resolver and show the results you see when pressing this combination? You can open the keybinding resolver using Ctrl+..

RoboWeb commented

Thx for reply.
For AltGr+c keybinding resolver show me:
keybindingresolver

Why AltGr+[something] = AltGr+Ctrl+[something] ?
I try AltGr+c and AltGr+Ctrl+c and keybinding resolver show me exactly this same.

Ben3eeE commented

On Windows Ctrl-Alt=AltGr so without the use of third party tools or some workaround a shortcut like AltGr+Ctrl will not work on Windows.

Ben3eeE commented

I can not reproduce the problem with AltGr-c.

  • Did you change keyboard layout while Atom was running?
  • Try completely exiting Atom and starting it using atom --safe.
RoboWeb commented

thx
I add in keymap.cson this, and its works for me:

'atom-workspace atom-text-editor:not([mini])':
  'ctrl-alt-z': 'unset!'
  'alt-c': 'ć'

'body':
  'ctrl-alt-o': 'unset!'
RoboWeb commented

Did you change keyboard layout while Atom was running?

I do not change any keyboard layout

Try completely exiting Atom and starting it using atom --safe

I run in this mode (of corese: remove before my changes in keymap.cson) and AltGr-c works properly...

Ben3eeE commented

Do you still have keyboard-localization installed? Can you try disabling or uninstalling that and then restart Atom to see if AltGr-c works?

RoboWeb commented

I disabled it before. Now I uninstall keyboard-localisation tottaly... Now AltGr-c works corectly, but AltGr-C conflicting with css-minifier... :)
keybindingresolver-2
...but I can handle it my self :)

thx

Ben3eeE commented

You're welcome for the help. Closing this issue since everything seems to be working 🙂

  • 👍1
pankuleczka commented

Let me just add that it seems the "Find in Current Buffer" input field also has problems with it's shortcuts (namely "Match Case" and "Only in Selection" triggering instead of a localised letters) - @Ben3eeE - is this also covered in 1.13? :)

Ben3eeE commented

@damieng ☝️ regarding Ctrl-Alt bindings in find-and-replace.

damieng commented

Yeah, we need to unbind those in find-and-replace. I couldn't find any sensible alternatives but am open to suggestions.