atom/deprecation-cop

Wrong indentation in deprecation cop

Closed this issue · 7 comments

From @goffreder on May 20, 2015 7:34

In the list of the "Deprecated selectors", if you expand one row, the next one becomes indented as it's part of the row above. See screenshot.

schermata 2015-05-20 alle 09 33 47

Copied from original issue: atom/atom#6863

@goffreder I'm having trouble reproducing this:

screen shot 2015-05-20 at 09 42 21

Which version of Atom are you using exactly and which themes? And if you run Atom with atom --safe ., and then open Deprecation Cop -- are the deprecations for your keymap.cson and styles.less file still incorrectly indented?

I'm running Atom 0.200.0 on OSX 10.10.3. I'm using the Seti theme, version 0.7.1.

I ran atom in safe mode but I get the same issue...

schermata 2015-05-20 alle 09 54 03

@goffreder Thanks for confirming -- I can reproduce this with the Atom Dark theme as well, but can't reproduce it with the default One Dark theme.

I'm gonna call @simurai for backup here ☎️ since this might require some fine tuning of pixels 🎨. I think the warning icons are causing problems here in some themes -- their position and height makes them cross to the other line vertically so subsequent lines are indented to the right of the icon of the previous line.

I can't reproduce it. But oddly, when I add some old classes to my styles.less. I can see the your local styles.less file, but it's empty.

screen shot 2015-05-20 at 6 06 11 pm

@simurai Are you perhaps not using the latest version of Atom? That problem with the empty list was a bug which was fixed recently: #48

@izuzak Yep, was on a different branch. Should be fixed in the next release.