atom/git-diff

Removed icon misaligned

Closed this issue · 3 comments

It appears that the top: .6em; setting in PR #32 is misaligning the removed icon in the gutter. It is pushing it too far down. Removing the top: .6em; rule fixes the problem.

Expected:

expected

Actual:

actual

@lee-dohm Reading the comments in #32 I believe that's actually the expected behavior. Having the icon in between lines shows more clearly where lines were deleted.

@dmnd Did I get that right?

Yeah, this is expected behavior now.

Taking a deeper look at it, I can see why it is desirable to have the symbol positioned the way it is, but the git-line-removed class is still assigned to the line above. I feel that's less than ideal ... but I guess I'm just grousing because I have to muck with my theme now 😉