atom/git-diff

Can't see indicators with Shadow DOM enabled

Closed this issue · 12 comments

dmnd commented

I have a problem that's probably my own: it doesn't repro in safe mode, so it must be due to some package I have installed.

The problem is that the green, yellow and red indicators do not appear in the gutter when I have Shadow DOM enabled. Inspecting the DOM, I see that the gutter still has .git-line-added on it. But there's no CSS rule that adds the border. Here's the CSS that gets applied in normal mode:

image

In safe mode, there is another rule that adds a green border.

image

I could understand if a package was overriding this rule, but somehow something I have installed seems to be preventing the rule from even being applied to the document. Any tips on debugging this?

I already tried disabling all my packages, but it didn't help.

Does it happen when you use a built-in theme?

dmnd commented

Yep, I'm using Atom Dark for both UI and syntax.

On 6 January 2015 at 17:02, Kevin Sawicki notifications@github.com wrote:

Does it happen when you use a built-in theme?


Reply to this email directly or view it on GitHub
#44 (comment).

Hmm, not sure what to suggest besides disabling packages one at a time and seeing which one is causing it that way.

dmnd commented

I did try mass-disabling all my packages, but it didn't seem to help.

I was doing it quickly and probably made a mistake though. I'll try it
again when I have more time.

On 6 January 2015 at 17:08, Kevin Sawicki notifications@github.com wrote:

Hmm, not sure what to suggest besides disabling packages one at a time and
seeing which one is causing it that way.


Reply to this email directly or view it on GitHub
#44 (comment).

Just to check, do you have any bundled packages installed to ~/.atom/packages or ~/.atom/dev/packages?

If you had git-diff there then I could see this happening.

IIRC there were some packages that changed the styling of the gutter to not conflict with the git-diff. I think it was the linter? I cant remember though. I would find any package that puts something in the gutter, disable it and reload.

@dmnd You might want to try @mark-hahn's package-cop, it is designed specifically to help with this kind of bisect style search.

dmnd commented

@kevinsawicki is the winner 😄

I need to remember to apm unlink after working on packages...

I need to remember to apm unlink after working on packages...

Yeah, when things go wrong for me the first command I run is apm unlink -a

dmnd commented

Thanks @lee-dohm I didn't realise a package bisector was released! I linked it from atom/atom#2357.

I'll definitely apm unlink -a in the future. Thanks all!

@kevinsawicki is the winner

Damn. I really wanted that new car

dmnd commented

Damn. I really wanted that new car

🚲 is the best I can do for you

On 6 January 2015 at 17:31, Ben Ogle notifications@github.com wrote:

@kevinsawicki https://github.com/kevinsawicki is the winner

Damn. I really wanted that new car


Reply to this email directly or view it on GitHub
#44 (comment).