atom/git-diff

Delete icon has spell-check underline

Closed this issue · 8 comments

All other icons in the gutter look fine, but the delete icon has a red spelling error underneath it.

image

Thanks for the report -- I'm seeing that as well. Wondering if @simurai can 🎨-away that line 😄

The red dotted line is intended. It should make it easier to see where a line got removed. Maybe could be changed to solid to make it less like spell check.

screen shot 2015-08-25 at 9 29 44 am

But something is strange with the icon in the initial screenshot. It should be a triangle and not a short 2px line (above) the dotted one.

@kayone Do you see the same when switching to other themes. The dotted line is mostly added in the One themes.

I see the triangle when disabling Show Icons in Editor Gutter

image
image

^ two screenshots when the mode is toggled between the two,

ohh.. I didn't even know that Show Icons in Editor Gutter exists. I guess the "something is strange with the icon" is a minus icon. 😅

ok, yep.. when icons are shown, the dotted line looks wrong.

ok, this should be fixed in the next One themes update. @kayone thanks for the issue.

Thank you so much for being so responsive.

I noticed this was fixed in https://github.com/atom/one-light-syntax when I checked other themese it seemed like they all had the same issue.

From the core themes, I think the dotted lines only got added to One dark and One light. Some community themes that forked from One still have it.