atom/git-diff

Does not work

Closed this issue ยท 29 comments

Plugin flat out does not work. No lines are highlighted. Win7. Tried restarting, and multiple projects. Have TortoiseGit installed if that makes a difference. I see modified files highlighted, but not lines. Works on Win10 laptop.

Have you followed the suggestions in the Debugging document? Also, could you give the following information?

  • Which version of Atom are you using?
  • Can you reproduce the issue after completely exiting Atom and restarting using atom --safe?
  • When you open Atom are you opening the root of the Git repository?
  • Is the directory you're opening a Git repository?

Version 1.4.3
I can reproduce in safe mode
The project folder added is the root of a git repository.
Went through the debugging document.

I just copied the folder to desktop, and opened it, it works on the copy. Do symlinks affect it? My webroot has the files, but there is a symlink to it. It is weird because the files in the file tree show what is modified, but the line numbers are not marked.

I reopened assuring I was opening the original, and not the symlinked folder, and it works. So apparently the file tree works with symlinks but not the line diff.

I have actually just recently just started getting this issue also. I ran in safe mode and was able to reproduce. Or at least I think it is the same issue.

The file status for change does not update until Atom window loses focus, even on save. I am also running Windows 7, Atom version 1.5.0. .git folder is at root.

Even when the file is marked as have diffs, I run the toggle diffs command and it says their are no differences even though I know there is (checking git diff) and it does not mark the line in the gutter.

Made a quick video to show what I am talking about
https://youtu.be/8FDo9dnC9M0

Atom version 1.5.3. Just started experiencing this today.

Works under atom --safe.

When you open Atom are you opening the root of the Git repository?

Yes. atom .

Is the directory you're opening a Git repository?

Absolutely.

ping @lee-dohm

I use the Seti theme by default but changing it does not appear to help. This only shows up in safe mode.

Considering I work in a very large project this plugin is extremely important to me. โค๏ธ

@Fishrock123 Are you also on Windows 7?

@lee-dohm Nope, OS X 10.10.5 (14F1605)

For anyone experiencing this issue: if you open up the dev tools (Cmd+Shift+I or Ctrl+Alt+I), are there any errors relating to git-diff in the console?

@50Wliu No errors.

@Fishrock123 What does this mean?

Works under atom --safe.

Does it mean that things work as expected? Or that the bug reproduces?

@lee-dohm The icons appear in the gutter under --safe mode. They do not appear when I regularly launch atom (atom .).

One thing of interest: I have two versions installed, probably because I had it installed since before it was bundled.

Disabling one disables both.

screen shot 2016-02-21 at 5 25 40 pm

@Fishrock123 That sounds like one of the community packages you have installed is causing the problem. People have reported having success using the package-cop package to track down offending packages.

Update: removing the git-diff v1.0.0 (Community Package one) resolves the issue.

Glad it is fixed for you @Fishrock123 ๐Ÿ˜€

Just an update, haven't responded in a few days.

Updated my Atom to version 1.5.3 (and still on Win 7)
Still have the issue.
I run the "toggle diff list" command and it says no diffs, even if the file in the tree view is showing as changed and the git status/diff through terminal shows the diffs correctly.

Behavior matches exactly as stated in my previous post.

This still happens even with all community packages disabled, run in --safe

No errors in my console (at least relating to git-diff). @50Wliu

Package works as expected on both of my other machines
Win 7 and Win 10

Packages are mostly the same across all three, I honestly have no idea what could be causing this issue, sorry for being so unhelpful in finding the root of this issue. I'm avoiding fresh installing in hopes to locate the cause if you have any suggestions on where I should check.

Interestingly enough, it appears the bug only occurs if the repo is in my Desktop folder, but not if it somewhere else. I think xeridea's reply is on to something with the symlinks.

I was seeing the same issue as @Fishrock123, but could not uninstall the community package in Atom preferences.

I could see git-diff was installed twice when running

apm list

Running

apm uninstall git-diff

uninstalled the communiy package from ~/.atom/packages and fixed it for me.

just remove git-diff from ~./atom/package i had tested...it works

Do symlinks affect it?

#91?

I'd to confirm. I had the same issue of not seeing git indicators in the gutter. Removing the community git-diff package (apm uninstall git-diff) did the trick.

Dosn't work for me too.
ArchLinux
Atom 1.12.9
screenshot from 2017-01-06 19-56-55

Still doesn't work and there is no local package.
Atom 1.15.0
Git 2.12.1
git-diff 1.3.1

Guys I have discovered the problem! it was cause of my Synatx them... I have changed it to "One Light" and it is ok now.

FIXED: If you do File->Add Project Folder and add a folder that contains other folders with .git folders, it doesn't work. You have to add each folder containing a .git folder individually and then all the git-diff features work.

Broken in 1.15.0 for me too. I don't have any non-stock packages installed. Doesn't work for any language in any UI or Syntax theme.

image
The screen is crushed horizontally, how can i solve it!

For other hand I have problems with bitbucket/git, not rules commands alt-b, how can i fix it?

@Encr1pt3d https://discuss.atom.io/t/where-did-this-empty-space-come-from-how-do-i-get-rid-of-it/30226

For most questions about Atom there are a lot of options, check out:

On Discuss and in the Atom Slack team, there are a bunch of helpful community members that should be willing to point you in the right direction.

I am optimistically closing this issue since all the reports for this issue seems to have been resolved by various things ๐Ÿคž

  • Uninstalling git-diff when it was installed as a community package. apm uninstall git-diff
  • Changing to a different UI/Syntax theme
  • Running Atom in safe mode atom --safe
  • Ensuring that you have the .git folder in the top level atom/atom#2203

If you still encounter this issue even when trying all the above suggestions then please open a new issue and completely fill out the provided issue template.

Deleting the repo and cloning it again is the only thing that worked for me. Try it, if everything else fails.

1c7 commented

2018-5-14
remove git-diff from ~/.atom/packages using rm -rf git-diff work for me
after that I switch back to Atom editor
image
it work again, new line have green color indicate that