Gutter not agreeing with tabs, tree-view or git (gutter is incorrect)

[lee-dohm]

Reproduced on Atom v1.7.0-dev-19623b3 on Mac OS X 10.11.3. It does not repro on either v1.5.3 or v1.6.0-beta6.

Steps I used to (unsuccessfully) correct it:

1. Close and reopen the file
2. Close and restart Atom
3. Open Atom in Safe Mode
4. Open Atom in Safe Mode with --clear-window-state
5. Open Atom with only --clear-window-state
6. Clone the repository again in a new directory and open Atom there

I'll try bisecting next to see if I can track down where it went wrong.

[joshaber]

So the tree-view was wrong but the diff markers were right? Or do I have that backwards?

[lee-dohm]

Yeah, sorry ... the diff markers were wrong. Tree view and tabs were correct.

[joshaber]

Could you zip up the repo and post it somewhere accessible? This sounds really odd.

[lee-dohm]

Yeah, I'll do that.

On Tue, Mar 1, 2016 at 7:20 PM, Josh Abernathy notifications@github.com
wrote:

Could you zip up the repo and post it somewhere accessible? This sounds
really odd.

—
Reply to this email directly or view it on GitHub
#88 (comment).

[lee-dohm]

Forgot to post the bisect results. This was weird enough I wasn't sure if it was necessarily a git-diff change that did it, but the bisect tracked down the first occurrence to the update of Atom to git-diff v1.0.0.

[50Wliu]

I can reproduce this (I think).

1. Open a file that does not have a trailing newline.
2. Save it to trigger a newline being added (and observe that the diff marker appears on the wrong line).
3. Close Atom.
4. Discard changes through Git (in my case, Github Desktop).
5. Re-open Atom.
6. Observe that the diff marker is still there despite changes being discarded.

Closing and re-opening the file does not help.

Windows 10 x64, 1.7.0-dev-663d9b2, safe mode. The file in question has LF line endings if it matters.

[joshaber]

I've opened a PR on nodegit with the fix: nodegit/nodegit#938