Java 14's new record keyword is not highlighted properly

[fbricon]

Prerequisites

• Reproduced the problem in Safe Mode: https://flight-manual.atom.io/hacking-atom/sections/debugging/#using-safe-mode
• Followed all applicable steps in the debugging guide: https://flight-manual.atom.io/hacking-atom/sections/debugging/
• Checked the FAQs on the message board for common solutions: https://discuss.atom.io/c/faq
• Checked that your issue isn't already filed: https://github.com/issues?utf8=✓&q=is%3Aissue+user%3Aatom
• Checked that there is not already an Atom package that provides the described functionality: https://atom.io/packages

Description

Java 14's new record keyword is not highlighted properly

Steps to Reproduce

1. in a Java class, type record Point(int x, int y){}

Expected behavior:

record should be colored as a Java keyword, similar to class or interface

Actual behavior:

record looks meh

Reproduces how often:

100%

cc @Vigilans @akaroml

[sadikovi]

Can you link java documentation about record keyword? We just need to add it to the grammar, should be fairly easy to do.

[fbricon]

There: https://openjdk.java.net/jeps/359

[Eskibear]

Grammar

RecordDeclaration:
  {ClassModifier} record TypeIdentifier [TypeParameters] 
    (RecordComponents) [SuperInterfaces] [RecordBody]

RecordComponents:
  {RecordComponent {, RecordComponent}}

RecordComponent:
  {Annotation} UnannType Identifier

RecordBody:
  { {RecordBodyDeclaration} }

RecordBodyDeclaration:
  ClassBodyDeclaration
  RecordConstructorDeclaration

RecordConstructorDeclaration:
  {Annotation} {ConstructorModifier} [TypeParameters] SimpleTypeName
    [Throws] ConstructorBody

cited from the JEP above

[sadikovi]

We don't even support JDK 10 and 11 fully yet 😄. Feel free to open a pull request!

[Eskibear]

PR created. Below is its looking in vscode.

Before

After