module name and comments not highlighted in module-info.java

Question

module name and comments not highlighted in module-info.java

Opened this issue 3 years ago · 4 comments

Eskibear commented 3 years ago

Description

Also reported in redhat-developer/vscode-java#1384
JEP reference about module system: https://openjdk.java.net/jeps/261

Expected behavior:

com.foo.bar and java.base should be highlighted.
comments in Line 4 should be hightlighted.

Versions

it's tested on vscode@1.53.0-insiders, should be latest release of atom/language-java

Answer 1 · 2021-01-20T02:37:51.000Z

@sadikovi Can you take a look please? FYI that we might be able to work "module names" around via semantic highlighting. So comments part should have a higher priority if you are short of bandwidth...

Answer 2 · 2021-01-20T04:17:08.000Z

I just created a PR against the comments part. please take a look.

Answer 3 · 2021-01-23T08:31:12.000Z

Shall we close this issue or is there anything else left to do?

Answer 4 · 2021-01-25T03:44:42.000Z

com.foo.bar and java.base should be highlighted.

It would be better if qualified module names can be highlighted.