atom/language-php

PHP syntax highlighting does not correctly detect end of string

Opened this issue · 1 comments

Prerequisites

Description

When I use a string variable formatted as in the example, code after the variable is incorrectly coloured

This is what it ends up looking like for me:
Screenshot from 2022-04-07 20-48-23

I'd expect this to parse the string correctly. The output should look more like this:
Screenshot from 2022-04-07 20-50-07

Test case:

<?php

$test = 'AND [' . $foo['bar'];

// hi i am a comment
if (true) {
    print 'test';
}

Steps to Reproduce

Create a test file, test.php with the contents from the test case

Expected behavior: [What you expect to happen]
Screenshot from 2022-04-07 20-50-07

Actual behavior: [What actually happens]
Screenshot from 2022-04-07 20-48-23

Reproduces how often: [What percentage of the time does it reproduce?]
100%

Versions

You can get this information from copy and pasting the output of atom --version and apm --version from the command line. Also, please include the OS and what version of the OS you're running.

Additional Information

VS Code Version: 1.66.0
Commit: e18005f0f1b33c29e81d732535d8c0e47cafb0b5
Date: 2022-03-30T05:50:41.156Z
Electron: 17.2.0
Chromium: 98.0.4758.109
Node.js: 16.13.0
V8: 9.8.177.11-electron.0
OS: Linux x64 5.13.0-39-generic snap

Originally from @pedroterzero in microsoft/vscode#147037

Seems similar to #418