keytar 7.7.0 incorrect electron prebuilts
umerkk opened this issue · 4 comments
Hi
I am trying to use Prebuilt keytar using the correct sysroot & gcc for our users (since prebuilt on GitHub releases uses new glibc).
We use Electron-Builder to rebuilt our native dependencies.
However, I noticed that the Prebuild step on node-keytar now tries to download files that do not exist.
build native dependency from sources name=keytar version=7.7.0 platform=linux arch=x64 reason=prebuild-install failed with error (run with env DEBUG=electron-builder to get more information) error=prebuild-install info begin Prebuild-install version 6.1.4 prebuild-install WARN install prebuilt binaries enforced with --force! prebuild-install WARN install prebuilt binaries may be out of date! prebuild-install info looking for local prebuild @ prebuilds/keytar-v7.7.0-electron-v89-linux-x64.tar.gz prebuild-install info looking for cached prebuild @ /home/bokken/.npm/_prebuilds/ef0a9c-keytar-v7.7.0-electron-v89-linux-x64.tar.gz prebuild-install http request GET https://github.com/atom/node-keytar/releases/download/v7.7.0/keytar-v7.7.0-electron-v89-linux-x64.tar.gz prebuild-install http 404 https://github.com/atom/node-keytar/releases/download/v7.7.0/keytar-v7.7.0-electron-v89-linux-x64.tar.gz prebuild-install WARN install No prebuilt binaries found (target=13.2.3 runtime=electron arch=x64 libc= platform=linux)
I wonder what is the fallback scenario here?,
if it does node-gyp rebuild i do not understand why it gives us a GLIBC problem.
However if I place a correctly prebuilt tgz in the prebuilt folder, although it gives me the same error, but somehow it uses it and package the app correctly.
newb question, im sure...but how does one get these correctly prebuilt binaries? my project has been stuck for months because of this...
Here, you can use this custom binaries of prebuild-install to point to your locally built prebuilt binaries for the project.
https://github.com/prebuild/prebuild-install#custom-binaries
Electron-builder should be looking for N-API builds in GitHub releases, but in your case it looks for electron-specific builds. Could you please try updating your Electron-builder version? This issue was fixed in develar/app-builder#47
There was a similar report in this issue, but the latest report is that it's all working for them now
@dennisameling, im using electron forge, not builder. do i need to switch to builder to finally make keytar work on things other than linux x64? win32 x64 would be great, but i really need linux armv7l...