PathWatcher.watch spams stderr for nonexistent files
Closed this issue · 7 comments
There's no way to call PathWatcher.watch("filename") so that it doesn't print to stderr if the file doesn't exist (fprintf on Mac, perror on Linux). Even if you check to see if the file exists first, there's room for a race condition. So if you want to use PathWatcher in a console program (as opposed to the invisible background process of some other UI), there's no way to avoid stderr potentially getting spammed with an error message.
(Also, it Would Be Nice (TM) if you could pass a nonexistent file to PathWatcher.watch and PathWatcher did the appropriate wrapper directory watches to notify you when it's created, but that's a separate issue.)
I'd be happy to submit a PR to remove the stderr prints, but I suspect that Atom may actually appreciate having them available somehow, and I'm not an expert on the proper way to manage memory around strings in Node/V8 C++. I guess you would want to get the error message into the NanThrowTypeError call?
Ideally, the error could look something like the errors that fs module functions return, with e.code === 'ENOENT' and all. Does that seem reasonable?
+1
+1
+1
+1
Can you please respond @kevinsawicki.
The bad file watching performance in Meteor makes it impossible to develop bigger projects with non high-end hardware. This package could be the solution to this problem ;-) :-)
+1
Apologies for how long this took to get fixed, but all the error logging has been removed in the 2.0.7 release which was just published.