atom/node-pathwatcher

Corrupts (Most) Binary Files

Opened this issue · 0 comments

kans commented

Atom corrupts binary files in many (most?) cases. To test:

  1. make a binary file (eg a tarball)
  2. md5 tarball
  3. open file in atom
  4. save file (you can make a change and undo if you want)
  5. md5 tarball

Pathwatcher just assumes everything is utf8 (before reading the files).
example: https://github.com/atom/node-pathwatcher/blob/master/src/file.coffee#L215

I don't really want to edit binary files in atom (its too damn slow for one thing), but accidentally opening a binary file and saving it is a thing that happens.