atom/scandal

isPathIgnored doesn't work with some ignoredNames

Opened this issue · 5 comments

alvaromartin commented

I just posted in discuss.atom.io explaining in depth an ignoredNames inconsistency issue between tree-view, fuzzy-finder and find-and-replace.

https://discuss.atom.io/t/ignorednames-issue/13299

I summary, scandal file search indexing is inconsistent with fuzzy-finder because instead of matching full file paths it's using relative file paths.

https://github.com/atom/scandal/blob/master/src/path-filter.coffee#L79

benogle commented

Based on your explanation, I feel like fuzzy-finder should use relative paths. Then your example becomes:

'global':
  'core':
    'ignoredNames': [
       'static/**'
    ]

Also, I rather like being able to type src into the paths box in find and replace to only search the src dir of my project.

alvaromartin commented

I just tried

'global':
  'core':
    'ignoredNames': [
       'static/**'
    ]

and now both static folders are ignored when I search.

benogle commented

and now both static folders are ignored when I search.

Is this good or bad?

alvaromartin commented 
projects
  project
    app
      static // dont want to ignore
        test.js
    static // want to ignore
      test.js

bad