can't focus on the search box with keyboard in keybindings view
Opened this issue · 3 comments
@tr15tan commented on Oct 6, 2018, 9:57 AM UTC:
Prerequisites
- [x ] Put an X between the brackets on this line if you have done all of the following:
- Reproduced the problem in Safe Mode: https://flight-manual.atom.io/hacking-atom/sections/debugging/#using-safe-mode
- Followed all applicable steps in the debugging guide: https://flight-manual.atom.io/hacking-atom/sections/debugging/
- Checked the FAQs on the message board for common solutions: https://discuss.atom.io/c/faq
- Checked that your issue isn't already filed: https://github.com/issues?utf8=✓&q=is%3Aissue+user%3Aatom
- Checked that there is not already an Atom package that provides the described functionality: https://atom.io/packages
Description
[can't focus on the search box with keyboard]
Steps to Reproduce
- open an arbitrary file
- use the command palette to open the settingsview : show keybindings panel
- try to focus on the "search keybindings" box with keyboard
Expected behavior: [can focus on the "search keybindings" box with keyboard]
Actual behavior: [can not focus on the "search keybindings" box with keyboard]
Reproduces how often: [must]
Versions
Atom : 1.31.0
Electron: 2.0.7
Chrome : 61.0.3163.100
Node : 8.9.3
Linux tristan-home 4.15.0-36-generic #39~16.04.1-Ubuntu SMP Tue Sep 25 08:59:23 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Additional Information
Any additional information, configuration or data that might be necessary to reproduce the issue.
This issue was moved by rsese from atom/atom#18203.
@rsese commented on Oct 9, 2018, 6:41 AM UTC:
Thanks for the report! I can reproduce on macOS 10.12.6 with 1.33.0-nightly10.
I also noticed that the Open Config Folder does get highlighted as I tab.
A recent issue 21092 in atom/atom seems to be related to this.
Prerequisites
- Put an X between the brackets on this line if you have done all of the following:
- Reproduced the problem in Safe Mode: https://flight-manual.atom.io/hacking-atom/sections/debugging/#using-safe-mode
- Followed all applicable steps in the debugging guide: https://flight-manual.atom.io/hacking-atom/sections/debugging/
- Checked the FAQs on the message board for common solutions: https://discuss.atom.io/c/faq
- Checked that your issue isn't already filed: https://github.com/issues?utf8=✓&q=is%3Aissue+user%3Aatom
- Checked that there is not already an Atom package that provides the described functionality: https://atom.io/packages
Description
When using the keyboard command to install a package the new pane does not autofocus to the input. Requires using the mouse to select the search field. Keyboard bindings should keep us at the keyboard for faster productivity.
Steps to Reproduce
- Ctrl+SHIFT+P
- Type 'install' or 'settings view'
- Choose the action 'Settings View: Install Packages and Themes' or 'Settings View: Show keybinds' via ENTER on the keyboard
Expected behaviour:
The opened pane window should be focused on the search 'text input' - especially when pressing Enter as the intension of the keyboard shortcut is to reduce the need for a mouseclick.
Actual behaviour:
Open pane window does not autofocus to the input consistently, more often than not it requires a mouseclick to focus on the search before you can keep typing.
Reproduces how often:
Inconsistent - it happens often but on repeating it can autofocus the input? If the Settings View is open when you perform the steps in another file it is more likely to occur although I'd need to experiment more. Been looking for a good first issue
Versions
OS: Windows 10 Home 19041.508
Atom : 1.50.0
Electron: 5.0.13
Chrome : 73.0.3683.121
Node : 12.0.0
Looks like focus is already being called, so not sure why it doesn't work. I tried adding a setTimeout and it works, so I suspect a race condition.