atom/settings-view

Allow comma in array setting value

Closed this issue · 0 comments

Prerequisites

Description

An array setting cannot have a comma value

Steps to Reproduce

  1. Set an array config value to ["1", ",", "2"] in config.cson
  2. Settings view will show '1, ,, 2'
  3. Add a array item in the settings view '1, ,, 2, 3'

Expected behavior:

Settings view should show '1, ,, 2'
After changing the setting config.cson should be ["1", ",", "2", "3"]

Actual behavior:

Settings view shows '1, ,, 2'
After changing the setting config.cson is ["1", "", "2", "3"]

Reproduces how often:
100%

Versions

Atom : 1.35.0-beta0
Electron: 2.0.16
Chrome : 61.0.3163.100
Node : 8.9.3

apm 2.1.3
npm 6.2.0
node 8.9.3 x64
atom 1.35.0-beta0
python 2.7.14
git 2.20.0.windows.1
visual studio 2015

Additional Information

#1103 will fix this