atom/solarized-dark-syntax

Javascript 'var' keyword missing

Closed this issue · 3 comments

'var' keyword not highlighted (like 'if' or 'function') in JS files/blocks.

Example:
var keyword missing

I suspect this belongs in the language-javascript package. It looks like the var keyword (and let as well) is classified as storage.modifier:

https://github.com/atom/language-javascript/blob/master/grammars/javascript.cson#L322-L329

When perhaps it should be classified as keyword.other like in language-csharp:

https://github.com/atom/language-csharp/blob/master/grammars/c%23.cson#L261-L264

Would you mind opening this there?

@jrodl3r @lee-dohm I have created a pull #23 that fixes this problem and also corrects color inconsistencies between the official solarized and the atom implementation

Fixed by #23