atom/solarized-dark-syntax

What would solarized dark 1.0.0 look like?

Closed this issue · 9 comments

Just wondering, as we are now at version 0.40.0. What do you all think would constitute 1.0.0? I mean it is just syntax highlighting, so I don't think moving to 1.0.0 would be too much trouble. Thoughts? @atom/solarized-maintainers

I think it's a good idea to release the current version as 1.0.0. It doesn't necessarily need new "features", but just to say that it's compatible with Atom 1.0.

Sure, just do it

Something that might be worth to sneak in before: Unifying solarized dark and light.

I have to look into it if it's possible, but the idea is like this: Both themes would be identical except maybe for the variables.less and syntax-variables.less files. The benefit would be that if somebody makes a PR to Solarized dark, let's say change something in the python.less file. Then we can just copy&paste that change over to Solarized light as well. So that both versions would get updated.

So the colors would be different, but the "logic" what should get highlighted, would be the same.

@schmittyjd let me know if you think it's a good idea and I'll take a look.

@simurai a unification of the repos could be nice.

ok, I'll give it a try.. and once it's done, we can release both as 1.0.0.

@benogle appropriate

Waaaaait...

64922817

  • Match other ports #57
  • Unify dark and light
  • 1.0.0 🎉

Ok.. 1.0.0 is released. 🎉

@schmittyjd Thanks for all your contributions.