Build fails for Electron 7 + Node 12
Closed this issue · 0 comments
sergei-dyshel commented
When building for Electron 7 with Node 12.16.1, e.g.
export npm_config_target=7.1.10
export npm_config_disturl=https://atom.io/download/atom-shell
npm install
I'm getting many errors of this kind:
../src/bindings/range-wrapper.cc:18:52: error: no matching member function for call
to 'Get'
auto start = PointWrapper::point_from_js(object->Get(Nan::New(start_string)));
~~~~~~~~^~~
/Users/sergei/Library/Caches/node-gyp/7.1.10/include/node/v8.h:3502:43: note:
candidate function not viable: requires 2 arguments, but 1 was provided
V8_WARN_UNUSED_RESULT MaybeLocal<Value> Get(Local<Context> context,
^
/Users/sergei/Library/Caches/node-gyp/7.1.10/include/node/v8.h:3505:43: note:
candidate function not viable: requires 2 arguments, but 1 was provided
V8_WARN_UNUSED_RESULT MaybeLocal<Value> Get(Local<Context> context,
^
Looks like v8 version used, doesn't have deprecated signatures Object::Get
, Object::Set
etc., used here.