atom/tree-view

Atom 1.37.0 does not properly track (grey out) `**` in .gitignore

Opened this issue · 4 comments

Atom 1.37.0 does not properly track (grey out) `**` in .gitignore
rsese commented

Thanks for the report! Reproduced with 1.37.0 on macOS 10.12.6:

ignore-1 37 0

And with 1.36.1:

ignore-1 36 1

This seems to be caused by a regression in libgit2 introduced via an upgrade in atom/git-utils#91.

For now, there is a workaround. Instead of **.log, use **/*.log instead. Honestly, that makes more sense, but you're right that Git command line tools seem to support **.log whereas libgit2 currently doesn't.

In fact, I think that the syntax you're using is accepted by Git, but is somewhat incorrect. I think you're following into this bucket (from the man gitignore):

o   Other consecutive asterisks are considered regular asterisks and will match according to the previous rules.

So I think you could also replace **.log with *.log and get the same effect.

I've reported the issue in libgit2/libgit2#5093.