ci' command does not work

Question

ci' command does not work

Closed this issue 6 years ago · 17 comments

mushketyk commented 9 years ago

Version: 0.59.0

How to reproduce:

Create a new file
Write: 'my-project'
In normal mode set cursor to character "o"
Enter the following command: ci'

What happens: nothing
What should happen: "my-project" should be removed and editor should enter insert mode

Answer 1 · 2015-08-31T14:05:01.000Z

@mushketyk can you please check what the Key Binding Resolver (toggled with cmd-. or in the Packages menu) shows when you've pressed ci'?

Answer 2 · 2015-09-05T17:01:06.000Z

@jacekkopecky Hi, I could only find bindings for "c" in Packages -> Settings View -> Show Keybindings:
c vim-mode:change Vim Mode atom-text-editor.vim-mode:not(.insert-mode)

Answer 3 · 2015-09-05T17:02:21.000Z

I also noticed that I can reproduce this bug only from time to time and if I restart Sublime everything works fine again.

Answer 4 · 2015-09-05T18:26:36.000Z

I'm especially interested in what the keybinding resolver shows when you press c and ' please. Also, you are restarting Atom along with Sublime, right? 😃

Answer 5 · 2015-09-06T14:57:25.000Z

I am a new vim-mode user and this is a limitation I have encountered as well.

The Key Binding Resolver shows i'.

And here is the code I am trying to perform the operation on:

ExUnit.start

defmodule MyTest do
  use ExUnit.Case
    test 'i wanna replace text in here pls' do
      assert 1 + 1 == 2
    end
end

Answer 6 · 2015-09-12T01:37:56.000Z

Is there any more information you would like from me?

I noticed that ci{ etc. works fine.

Answer 7 · 2015-09-12T06:06:17.000Z

@alexbooker can you reliably reproduce the condition? I tried ci' in various places of your test name and it worked properly. And if you can reproduce it, does it also show up when you disable packages other than vim-mode and restart Atom?

It could also be that the user sometimes, through a distraction, spends more than a second between typing i and ' – that would cancel the Atom command.

Answer 8 · 2015-09-12T11:20:33.000Z

Can you reliably reproduce the condition?

@jacekkopecky Yes, I can.

And if you can reproduce it, does it also show up when you disable packages other than vim-mode and restart Atom?

Yes.

It could also be that the user sometimes, through a distraction, spends more than a second between typing i and ' – that would cancel the Atom command.

It does work with ci{ etc. so I do not think this is the problem.

I am running Atom 1.0.11 on Windows 10 64bit. I'll try reinstalling Atom now.

Any other questions I can answer to help solve this? Thanks.

Answer 9 · 2015-09-12T15:10:57.000Z

@alexbooker can you also please paste the output of apm list --installed here (and/or try to disable all community packages except vim-mode)? Thanks.

Answer 10 · 2015-09-12T15:47:51.000Z

Eureka!

This issue stems from using English (United Kingdom) keyboard layout. It works if I use English (United States).

Makes sense because @mushketyk and I are both in the United Kingdom.

How to reproduce:

(On Windows 10)

Change keyboard layout to English (United Kingdom) (tutorial).
Follow steps in OP

Other:

I dunno if this is a problem with vim-mode or Atom in general because vim-surround commands that involve ' or " do not work with English (United Kingdom) either... //cc @gepoch

Answer 11 · 2015-09-12T17:49:40.000Z

Do you need to press AltGr to get to '?

Answer 12 · 2015-09-12T19:01:39.000Z

@50Wliu No I do not - I never use AltGr.

Answer 13 · 2015-09-14T10:57:43.000Z

Is there any more information I can provide? I really miss this feature 😢

Answer 14 · 2015-09-14T11:13:10.000Z

@alexbooker in case you haven't already, can you please try it with https://atom.io/packages/keyboard-localization installed? Cf #709
I don't have Windows so I can't reproduce it.

Answer 15 · 2015-09-14T11:40:54.000Z

@jacekkopecky That definitely helped - now I can use ci" but ci' still does not work. Thanks.

Unfortunately, I adopted a single-quote convention in my app (i.e. I use ' instead of "). Any other thoughts?

Answer 16 · 2015-09-14T13:39:51.000Z

Upon further inspection keyboard-localization works very well for me and it should for @mushketyk, too.

I generated a custom keymap using these instructions:

{
    "50": {
        "shifted": 34
    },
    "192": {
        "unshifted": 39
    }
}

And now ci" and ci' work fine. vim-surround commands involving ' and " work fine now as well.

Answer 17 · 2018-04-05T16:59:04.000Z

As stated in the README, this package is no longer maintained and is deprecated. We recommend that people use the vim-mode-plus package instead. Because of this, we are archiving this repository and closing all issues and pull requests. Thanks very much for your support and contributions!