Issue with v12 of Foundry
Closed this issue · 10 comments
I updated to v12 of foundry last week and when working on a new map today, it seems I cant scale the background. The tool is available on the left side as normal, but nothing happens when choosing the "set grid" option
it looks like this module is not going to have a long term support, am i correct?
it looks like this module is not going to have a long term support, am i correct?
Doesn't look like it. Pretty much nothing works in v12.330
Error: Error thrown in hooked function '' for hook 'drawGridLayer'. The supplied DisplayObject must be a child of the caller
[Detected 3 packages: token-auras(2.7), lib-wrapper(1.12.14.0), monks-scene-navigation(12.01)]
onError foundry.js:654
call_wrapped libWrapper-wrapper.js:507
<anonymous> listeners.js:138
onError#0 libWrapper-wrapper.js:187
#call foundry.js:636
callAll foundry.js:589
<anonymous> foundry.js:33713
draw foundry.js:33709
_draw foundry.js:28263
_draw foundry.js:50656
<anonymous> foundry.js:28247
draw foundry.js:28244
#draw foundry.js:25051
draw foundry.js:24936
view foundry.js:21358
call_wrapped libWrapper-wrapper.js:507
sceneView monks-scene-navigation.js:608
call_wrapper libWrapper-wrapper.js:616
view#0 libWrapper-wrapper.js:189
_onClickScene foundry.js:83491
_onClickScene monks-scene-navigation.js:367
setTimeout handler*_onClickScene monks-scene-navigation.js:365
jQuery 9
activateListeners foundry.js:83402
activateListeners monks-scene-navigation.js:205
_render foundry.js:5866
_render foundry.js:83308
_render monks-scene-navigation.js:408
render foundry.js:5792
render foundry.js:83301
render foundry.js:12278
_onModifyContents foundry.js:12430
#handleUpdateDocuments foundry-esm.js:56570
_updateDocuments foundry-esm.js:56446
update foundry-esm.js:12328
updateDocuments foundry-esm.js:11473
update foundry-esm.js:11583
callback monks-scene-navigation.js:278
#onClickItem foundry.js:68598
jQuery 3
Caused by: Error: The supplied DisplayObject must be a child of the caller
[Detected 3 packages: token-auras(2.7), lib-wrapper(1.12.14.0), monks-scene-navigation(12.01)]
getChildIndex Container.ts:251
<anonymous> main.js:193
#call foundry.js:632
callAll foundry.js:589
<anonymous> foundry.js:33713
draw foundry.js:33709
_draw foundry.js:28263
_draw foundry.js:50656
<anonymous> foundry.js:28247
draw foundry.js:28244
#draw foundry.js:25051
draw foundry.js:24936
view foundry.js:21358
call_wrapped libWrapper-wrapper.js:507
sceneView monks-scene-navigation.js:608
call_wrapper libWrapper-wrapper.js:616
view#0 libWrapper-wrapper.js:189
_onClickScene foundry.js:83491
_onClickScene monks-scene-navigation.js:367
setTimeout handler*_onClickScene monks-scene-navigation.js:365
jQuery 9
activateListeners foundry.js:83402
activateListeners monks-scene-navigation.js:205
_render foundry.js:5866
_render foundry.js:83308
_render monks-scene-navigation.js:408
render foundry.js:5792
render foundry.js:83301
render foundry.js:12278
_onModifyContents foundry.js:12430
#handleUpdateDocuments foundry-esm.js:56570
_updateDocuments foundry-esm.js:56446
update foundry-esm.js:12328
updateDocuments foundry-esm.js:11473
update foundry-esm.js:11583
callback monks-scene-navigation.js:278
#onClickItem foundry.js:68598
jQuery 3
foundry.js:655:30
Hello, I have proposed a PR #4 to fix all of that and add support for V12 (build 330).
While I do not know if maintainers are here, in the meantime you can use the module.json from my personal repo.
https://raw.githubusercontent.com/TheGoodwin/scaleGrid/master/module.json
@TheGoodwin wow, awesome! I don't know if the maintainer is here, and i have no idea if you would like to start your own module repo because it's a lot of work with no reward, but, I really really appreciate your work!
Thank you.
For now I have my repo from which my Foundry is getting the up to date version.
If there are no maintainer when the module needs to be updated again or if there is are a lot of people in need I may set up a clone on the Foundry module repo as well. In the meantime, I have hope the PR will be approved and we can goi back to follow this repository.
I do not plan on adding new features bu only to maintain it as long as possible for me.
given the fact that this issue has started sometime in May, that was 3 months back and no update, and the maintainer @atomdmac is busy with other repos because i do see a lot of activities on github, i feel like maybe wait a few days, with little hope.
in the meanwhile, i will switch to your repo and start using it. Thank you again!
Hey everyone - sorry for the delay. I'll need to revisit my GitHub notifications as I don't think I got any for this discussion. Thanks to @TheGoodwin for the fix.
@atomdmac I assume you haven't used Foundry for a long time then. Your module is pretty useful, just wanted you to know.
@Rommel-holmes Great to hear that this is being used by others, though I can't really take credit for any of the actual work :P I forked this from another intrepid Foundry user.
A release has been created for v1.4.5 here.