atomicpages/pretty-checkbox-react

Setting the animation prop doesn't add the CSS class

labber opened this issue · 2 comments

labber commented

Describe the bug
Adding the prop Animation="tada" to the component doesn't add the class in the source.

pretty checkbox react version: 1.0.5

To Reproduce
Steps to reproduce the behavior:

  1. Add prop Animaton="tada" to the component
  2. Save and Load the page
  3. Click on the checkbox to test animation
  4. Check the source and notice there is no class for the animation

Expected behavior
The class p-tada to be in the source code.

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: macOS 10.14.3
  • Browser: Chrome
  • Version: 72.0.3626.121
atomicpages commented

Looks like a larger regression that's affecting all animations! Not sure how this happened 🤔
Whoooaaa caused by dae83f4

atomicpages commented

Fixed in 80729d5. Thanks for making PCR better! Unit tests also added to ensure this issue doesn't happen in the future 😉