atomicpages/react-accessible-shuttle

`MOVE_ALL` reducer is broken for disabled items

atomicpages opened this issue · 0 comments

There are two main issues here:

  • Reducers shouldn't be accessing the DOM
  • Performance impact for large lists

Possible Solutions

  • Cache index of disabled items. Currently status is set on the item itself, but maybe it's required in the Shuttle state (like how pre-selected items are handled).
    • Disabled items cannot be based on index, but rather the content
    • For object types, the component can only check ===, maybe this is exposed as a hook too?