Linking Images (GitHub Actions)
Closed this issue · 4 comments
https://docs.atomist.com/integration/linking-images/#github-actions
@cdupuis - I didn't totally follow the explanation this morning but I think there are two things here.
- org.opencontainer metadata is now added automatically
- there's a way to configure the github actions so that PRs with multiple commits don't use merge commits
Can we improve our documentation here?
@slimslenderslacks I think there are a few things we could improve
- I think the
org.opencontainerlabels are now added automatically as seen in this Action execution https://github.com/jeanlaurent/kamoulox/runs/6226599761?check_suite_focus=true for this workflow file https://github.com/jeanlaurent/kamoulox/blob/master/.github/workflows/docker-image.yml#L31. Based on this I think we can reduce the set of labels that have to be added to just ourcom.atomist.containers.image.dockerfile - We should add a link and note to https://github.com/actions/checkout#checkout-pull-request-head-commit-instead-of-merge-commit to help configure the checkout-action for PR builds.
This issue has been automatically marked with stale because it has not had any activity in last 21 days. It will be closed in 14 days if no further activity occurs. To prevent closing, label with defer or blocked.
This issue has been automatically marked with stale because it has not had any activity in last 21 days. It will be closed in 14 days if no further activity occurs. To prevent closing, label with defer or blocked.
This issue has been automatically marked with stale because it has not had any activity in last 21 days. It will be closed in 14 days if no further activity occurs. To prevent closing, label with defer or blocked.