About current tokens in get_random_walk func
Closed this issue · 2 comments
wxx07 commented
Line 425 in 74cea9b
It seems to me that current
here should be appended by indices of atoms, instead of sampled index from avail
, right?
Is that a mistake or a misunderstanding of mine?
NiklasGebauer commented
Hey,
the line should be correct. The naming and comments might be a little confusing.
The positions and types of atoms are sorted at the end of the function according to the order in which they appear in the generation trace:
Lines 449 to 452 in 74cea9b
The indices in current
correspond to the atoms after they have been sorted according to order
and not to the original atom indices in the input.
Hope this helps!
wxx07 commented
I get it now. Thanks!