atsa-es/marssTMB

fix par element

Closed this issue · 2 comments

eeholmes commented

par should be in marss form

> names(m1.em$par)
 [1] "Z"  "A"  "R"  "B"  "U"  "Q"  "x0" "V0" "G"  "H"  "L" 
> names(m1.tmb2$par)
 [1] "Z"  "A"  "R"  "B"  "U"  "Q"  "x0" "V0" "D"  "C"  "d"  "c"  "G"  "H"  "L" 
>
ericward-noaa commented

One of the changes I made to the dfa.hpp was only reporting the covariates when estimated,

marssTMB/src/TMB/dfa.hpp

Line 86 in 87e0067

if(est_covar) {

But maybe that'll mess up the ordering when not estimated -- so remove that flag + if block?

eeholmes commented

@ericward-noaa I am only working on marxss.hpp, so feel free to change dfa.hpp . For marxss.hpp, it takes a MARSS model object and uses the TMB map list to stop estimation of any fixed elements. Doesn't seem to affect speed.