Migrate from package:pedantic to package:lints

Question

Migrate from package:pedantic to package:lints

Closed this issue 3 years ago · 14 comments

Describe the solution you'd like

Per the guidance from dart-lang/lints:

in pubspec.yaml:

-  pedantic: ^1.11.0
+  lints: ^1.0.1

and in each analysis_options.yaml:

-include: package:pedantic/analysis_options.yaml
+include: package:lints/recommended.yaml

Answer 1 · 2021-10-07T20:14:15.000Z

Hey @XavierChanth, just going through our repos and found that you're using the pedantic dependency. Will this be code breaking while migrating to lints?

Answer 2 · 2021-10-07T20:54:16.000Z

Hey @XavierChanth, just going through our repos and found that you're using the pedantic dependency. Will this be code breaking while migrating to lints?

I don't think there should be an issue, the linter may ask for some additional formatting/changes though.

Answer 3 · 2021-10-10T03:37:08.000Z

How to work on this one? I see pubspec has the pedantic package, will replacing the package with lints work? I guess, nope.

Answer 4 · 2021-10-11T09:55:17.000Z

@prasadsunny1 see https://github.com/atsign-foundation/at_widgets/pull/232/files for an example of a similar replacement

@XavierChanth I'm assuming you want flutter_lints rather than just Dart lints

Answer 5 · 2021-10-11T10:05:33.000Z

Understood, PR coming this way soon

Answer 6 · 2021-10-12T13:36:51.000Z

@prasadsunny1 see https://github.com/atsign-foundation/at_widgets/pull/232/files for an example of a similar replacement

@XavierChanth I'm assuming you want flutter_lints rather than just Dart lints

Sorry, was out on holiday.
I think package:lints is fine here, no flutter code in the project.

Answer 7 · 2021-10-14T21:00:24.000Z

All right, I'll create a fresh PR

Answer 8 · 2021-10-14T21:20:32.000Z

All right, I'll create a fresh PR

No need, continue pushing your changes and they will be added to this PR.

Answer 9 · 2021-11-04T10:19:52.000Z

Added flutter_lints as linter.
Applied few changes as per the info given by the analyzer

Answer 10 · 2021-11-04T10:21:30.000Z

file_manager.dart has a print statement in the catch statement. I have tried to replace it with logger.
Do you think passing logger to FileManager using constructor is a good idea and all the caller for it should be updated?

Answer 11 · 2021-11-04T10:24:08.000Z

CreateBase class has the property name which seems to be an override from the base class.
CreateCommand class has the property description which seems to be an override from the base class.

Answer 12 · 2021-11-04T10:25:38.000Z

android_manage.dart, line: 17
The analyzer is saying that for each should be converted to simple for loop`

Answer 13 · 2021-11-04T10:26:17.000Z

Please tell me if it is all right to do these changes

Answer 14 · 2021-11-04T10:27:11.000Z

Check the PR to understand the changes