Implement changes proposed in https://github.com/atsign-foundation/sshnoports/issues/292
Closed this issue · 1 comments
gkc commented
Is your feature request related to a problem? Please describe.
See atsign-foundation/noports#292
Describe the solution you'd like
See atsign-foundation/noports#292
- Deprecate
RemoteSecondary.isAvailable() - Remove Monitor's use of NetworkUtil.isNetworkAvailable
- Remove use of ConnectivityListener from NotificationServiceImpl
- Remove SyncServiceImpl's usage of NetworkUtil.isNetworkAvailable
- Remove AtClientValidation.validateAtKey's usage of NetworkUtil.isNetworkAvailable
- Adjust any unit tests which currently use mock network availability checks to simulate atServer reachability to instead use other mock approaches instead, without changing those tests's other setup or
expects - Remove the now-unused NetworkUtil class
- Add hostname, port and a checkInterval as optional parameter to ConnectivityListener constructor and use accordingly
- Deprecate ConnectivityListener class as it's not a core concern of the at_client package
gkc commented
Started work on this