Testability and Documentation for KeyStream

Question

Testability and Documentation for KeyStream

Closed this issue 2 years ago · 3 comments

XavierChanth commented 3 years ago

lead: @XavierChanth

See also at_client_sdk#519

See this PR.

Todos:

Write unit tests around at_stream package
Determine final repo for the package - my suggestion is at_client_sdk since end2end tests are required for this package
Complete usage + Documentation
Add onError callback parameter to all models

Answer 1 · 2022-06-02T01:34:55.000Z

@gkc Where should this live, within the SDK? separate package? I would like to put it in at_client_sdk so that I can take advantage of the end2end test suite. I think this could be used commonly enough that it could potentially be part of the SDK, instead of a separate package.

Answer 2 · 2022-06-06T17:31:52.000Z

Yeah that's my feeling also, Xavier

Answer 3 · 2022-06-10T20:29:32.000Z

PR39: This ticket is complete, awaiting Gary's review.